migrate away from erb #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4ldr
force-pushed
the
migrate_to_epp
branch
2 times, most recently
from
95232a6 to
f1c8e1b
Compare
bastelfreak
reviewed
Jan 17, 2025
bastelfreak
reviewed
Jan 17, 2025
bastelfreak
reviewed
Jan 17, 2025
| ) { | ||
| $records = $local_data.map |$record| { |
There was a problem hiding this comment.
there's a lot going on here. Can you please add some comments about what's happening?
There was a problem hiding this comment.
Updated let me know what's missing?
b4ldr
force-pushed
the
migrate_to_epp
branch
2 times, most recently
from
41fe534 to
c270c7e
Compare
b4ldr
commented
Jan 18, 2025
There was a problem hiding this comment.
if you have any idea on the spec test failure please say because im lost, specificly the error like
77) unbound::stub on archlinux-6-x86_64 unbound::address is expected to contain Concat::Fragment[unbound-stub-lab.example.com] with content supplied string
Failure/Error:
expect(subject).to contain_concat__fragment('unbound-stub-lab.example.com').with_content(
<<~ZONE
stub-zone:
name: "lab.example.com"
stub-addr: "10.0.0.10@10053"
stub-host: "ns1.example.com"
stub-host: "ns2.example.com"
stub-first: no
stub-no-cache: no
ZONE
expected that the catalogue would contain Concat::Fragment[unbound-stub-lab.example.com] with content set to supplied string
Diff:
<The diff is empty, are your objects producing identical `#inspect` output?>
# ./spec/defines/stub_spec.rb:47:in `block (5 levels) in <top (required)>'
| ) { | ||
| $records = $local_data.map |$record| { |
There was a problem hiding this comment.
Updated let me know what's missing?
b4ldr
force-pushed
the
migrate_to_epp
branch
2 times, most recently
from
8a52da2 to
b29a0e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the templating code to move away from erb and where possible use the print_config function
This PR is currently a WIP, couple of outstanding things
Also happy to split this up into separate PRs if needed