add curl_command as serverspec extension #89
+135
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Jan 14, 2025
There was a problem hiding this comment.
Should this be added to spec_helper_acceptance.rb, or should people need to explicitly opt-in to it with
require 'voxpupuli/acceptance/serverspec_extensions'
There was a problem hiding this comment.
I think it makese sense to load it by default? It's not expensive and makes the usage easier.
There was a problem hiding this comment.
My only worry is that it modifies serverspec without the user opting in for that.
But I would also lean towards "enable"
ekohl
reviewed
Jan 14, 2025
| end | ||
|
|
||
| def body_as_json | ||
| MultiJson.load(body) |
There was a problem hiding this comment.
Note to self: serverspec itself now depends on multi_json so this should be acceptable.
evgeni
commented
Jan 14, 2025
ekohl
reviewed
Jan 14, 2025
ekohl
reviewed
Jan 18, 2025
|
@ekohl added README |
evgeni
force-pushed
the
curl_command
branch
2 times, most recently
from
3476ae3 to
20a8256
Compare
otherwise the module is not found and Puppet reaches out to the forge
bastelfreak
approved these changes
Jan 18, 2025
|
The docs and the loading are not in sync (docs say default, code doesn't load by default) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.