-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add image endpoints #408
Open
jellejurre
wants to merge
3
commits into
vrchatapi:main
Choose a base branch
from
jellejurre:feat/add-image-endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2024
Rexios80
added a commit
to vrchatapi/vrchatapi-dart
that referenced
this pull request
Nov 11, 2024
This generates fine in dart: vrchatapi/vrchatapi-dart#26 |
It generates fine in all I've tested so far, but the multipart file type is either not supported at all or the mimetype is set wrong for it, so we'd have to test that either way |
C0D3-M4513R
added a commit
to vrchatapi/vrchatapi-rust
that referenced
this pull request
Nov 12, 2024
Signed-off-by: C0D3 M4513R <[email protected]>
jellejurre
added a commit
to vrchatapi/vrchatapi-rust
that referenced
this pull request
Nov 12, 2024
* Add multipart content type * Regenerate with vrchatapi/specification#408 Signed-off-by: C0D3 M4513R <[email protected]> * Use async file io and don't `unwrap` * Don't use file-io for multipart uploads/image endpoints --------- Signed-off-by: C0D3 M4513R <[email protected]> Co-authored-by: C0D3 M4513R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Currently a draft because it can only be merged once all generators are confirmed to work with it.
My current edits to the generators assume files are .png.
Generators: