Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for creating a module in a Canvas course #10

Closed
wants to merge 1 commit into from

Conversation

nelis73
Copy link
Collaborator

@nelis73 nelis73 commented Aug 30, 2024

Pull Request Description

As a test I added one of the new functions I suggested, i.e., create_module()

Type of Change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Other (please specify)

@tin900 tin900 self-requested a review August 30, 2024 13:33
@tin900 tin900 self-assigned this Aug 30, 2024
@tin900
Copy link
Contributor

tin900 commented Aug 30, 2024

Hi @nelis73 ,

Thank you for creating the pull requests!

In order for the pull request to be merged you will need to update your pull request using the following steps:

  • run devtools::document() in R to create the man pages for the new function(s)
  • run devtools::check() in R to check the package passes basic checks
  • in _pkgdown.yml add the function name in its appropriate section.

@tin900
Copy link
Contributor

tin900 commented Sep 2, 2024

Hi @nelis73 ,

Given that the other pull request has been approved and merged, can I close this pull request?

There were no other changes compared to the other pull request as far as I can tell?

Kind regards,

@nelis73
Copy link
Collaborator Author

nelis73 commented Sep 2, 2024

Hi @nelis73 ,

Given that the other pull request has been approved and merged, can I close this pull request?

There were no other changes compared to the other pull request as far as I can tell?

Kind regards,

Hi @tin900,

Yes, feel free to close it!
Niels

@tin900 tin900 closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants