Removed the redundant weight syncronization via torch seed

vwxyzjn · Jan 23, 2025 · 3456c05 · 3456c05
1 parent e757c8d
commit 3456c05
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/cleanrl/ppo_atari_multigpu.py b/cleanrl/ppo_atari_multigpu.py
@@ -213,7 +213,7 @@ def unwrap_ddp(model) -> Agent:
     args.seed += local_rank
     random.seed(args.seed)
     np.random.seed(args.seed)
-    torch.manual_seed(args.seed - local_rank)
+    torch.manual_seed(args.seed)
     torch.backends.cudnn.deterministic = args.torch_deterministic
 
     if len(args.device_ids) > 0:
@@ -235,7 +235,6 @@ def unwrap_ddp(model) -> Agent:
     agent = Agent(envs).to(device)
     if args.world_size > 1:
         agent = DDP(agent)
-    torch.manual_seed(args.seed)
     optimizer = optim.Adam(agent.parameters(), lr=args.learning_rate, eps=1e-5)
 
     # ALGO Logic: Storage setup