feat: replace leveldb with sqlite3 #365
Open
+113
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
for our use case, sqlite should work just about as well as leveldb. (it may be slightly slower, but requests to sqlite3 should be in the 1us-10us range).
leveldb on python has two drawbacks:
leveldb 1.23
andsnappy 1.1.9
wbolster/plyvel#129)How I did it
implement a "SqliteDB" with ttl for cached keys.
How to verify it
Description for the changelog
Cute Animal Picture