Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple changes to fix activation and deactivation of platform collector #105

Merged
merged 2 commits into from
May 5, 2022

Conversation

kenchris
Copy link
Contributor

@kenchris kenchris commented May 3, 2022

Use global objects instead of agents
More formal deactivation and activation of data delivery
Handling of unload and change in fully active

Fixes #102
Fixes #103
Fixes #104


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on May 5, 2022, 8:52 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

📡 HTTP Error 404: http://labs.w3.org/spec-generator/uploads/hFMUSA

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@kenchris kenchris changed the title Use global objects instead of agents and better handle unloading Multiple changes to fix activation and deactivation of platform collector May 5, 2022
@arskama
Copy link
Contributor

arskama commented May 5, 2022

LGTM

@kenchris kenchris merged commit fad9e48 into main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants