Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scroll-animations-1] Add all as a value for timeline-scope #9779

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[scroll-animations-1] Add all as a value for timeline-scope #9779

merged 1 commit into from
Jan 23, 2024

Conversation

bramus
Copy link
Contributor

@bramus bramus commented Jan 10, 2024

Fixes #9158.

@bramus bramus requested review from flackr and fantasai January 10, 2024 17:39
@bramus bramus added the scroll-animations-1 Current Work label Jan 10, 2024
@bramus
Copy link
Contributor Author

bramus commented Jan 12, 2024

@fantasai PTAL.

@bramus
Copy link
Contributor Author

bramus commented Jan 20, 2024

Or maybe @flackr or @andruud can LGTM this one?

flackr
flackr approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@bramus bramus merged commit 33f0414 into w3c:main Jan 23, 2024
1 check passed
@bramus bramus deleted the scroll-animations-1-timeline-scope-all branch December 30, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flackr flackr flackr approved these changes

@fantasai fantasai Awaiting requested review from fantasai

Assignees
No one assigned
Labels
scroll-animations-1 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[scroll-animations-1] Add a way for timeline-scope to pull up all contained timelines
2 participants
@bramus @flackr