Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify isTrusted bits in coalesced/predicted event lists #524

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Clarify isTrusted bits in coalesced/predicted event lists #524

merged 1 commit into from
Oct 23, 2024

Conversation

mustaqahmed
Copy link
Member

@mustaqahmed mustaqahmed commented Oct 23, 2024 •
edited by pr-preview bot
Loading

Closes #514.

Preview | Diff

@mustaqahmed mustaqahmed requested a review from smaug---- October 23, 2024 14:50
@mustaqahmed
Copy link
Member Author

@smaug----, Please take a look.

aprotyas
aprotyas reviewed Oct 23, 2024
View reviewed changes
Copy link

@aprotyas aprotyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a WPT for this behavior?

smaug----
smaug---- approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@smaug---- smaug---- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are notes only, and seem to clarify nicely the behavior.

Obviously if those coalesced events themselves are dispatched using JS, they become untrusted, but that is true for all the events anyhow.

@mustaqahmed
Copy link
Member Author

Is there a WPT for this behavior?

We have this test that will need to become non-tentative after this PR lands.

@mustaqahmed mustaqahmed merged commit 82a6df8 into gh-pages Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas left review comments

@smaug---- smaug---- smaug---- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coalesced and predicted event attributes within an untrusted event
3 participants
@mustaqahmed @smaug---- @aprotyas