-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-66: Replace 'character string' #67
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as the first change in this area.
@pfps Who merges PRs for this document? A document editor? |
As far as I know it has never been clear who should merge PRs. We have had problems with non-editors merging PRs, however. I thought that the rule for editorial PRs was to let them soak until there was a regular WG meeting and then if there were no problems with them then they were merged (by someone). Is this PR at that stage? |
The editors are the ones who are responsible for the document, and generally should be the one merging PRs. There may be exceptions, such as when there is a consensus that a non-editor go ahead with a specific change. For example, I'm not an editor, but I may update the contributors from time to time, and that probably doesn't require an editor to actually push the merge button. |
I am strongly of the opinion that only the chosen and committed Editors of each document should be merging PRs, and that only the rarest of changes should be made as a direct commit (without going through a PR) which should likewise only be pushed by an Editor. Any member of the WG (indeed, any member of the public) may submit such PRs, which the Editor should use their best judgement about merging — usually but not necessarily always waiting for specific approval by the WG, i.e., a spelling correction probably need not wait for group approval, while a normative change probably requires group approval and to have been submitted with/under relevant IPR commitments. |
Is there any reason not to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
See #66 (comment)
Preview | Diff