-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier svg code #41
Conversation
@@ -13,16 +13,26 @@ | |||
.bg { | |||
stroke-width: "0.5px"; | |||
} | |||
.bold { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice with classes like this if one wants to do custom styling 👍
Looks great! tried it out with chrome on macOS and can't see any issues. But i did notice a thing unrelated to this change (happens without this change also) that powerline.svg is rendered with wrong character dimensions until the windows is reiszed etc then it snaps to correct size... feels like browser bug? |
Good to know! |
Huh yes that seems unlikely |
This PR attempts to produce less verbose / more concise SVG code. The rendered graphics should stay the same.
BTW, I tried to make the background rects inherit
height
andy
attributes from a parent<g>
element, to reduce repetition, but apparently<g>
can only impose a style to child elements, not coordinates or dimensions.