Feature/highlights #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dida0423
commented
Jan 17, 2025
dida0423
commented
- [POST] /highlight/new/{story_id} - 새로운 Highlight (Parameters: Highlight name, Cover image) 생성 및 Story 저장
- Cover image 없을 시 스토리 이미지-> 커버 이미지 (스토리 여러개 있는 상태에서 커버 Story 삭제할 경우 exception handling 필요할 듯) (TODO)
- Story 없이 Highlight 생성 불가
- [PATCH] /highlight/add/{highlight_id}/{story_id} - 이미 존재하는 highlight에 story ID로 story 추가
- [GET] /highlights/{user_id} - 특정 유저의 모든 Highlight 반환
- [GET] /highlight/{highlight_id} - 특정 Highlight 반환
- [DELETE] /highlight/{highlight_id} - 특정 Highlight 삭제
- [DELETE] /highlightstory/{highlight_id}/{story_id} 특정 Highlight에서 Story 삭제
- 모든 Story 삭제 시 Highlight 삭제 처리 필요 (TODO)
cloNoey
reviewed
Jan 20, 2025
instaclone/app/story/views.py
Outdated
| if type(highlight_create_request.cover_image) == UploadFile: | ||
| cover_image = await medium_service.create_medium(highlight_create_request.cover_image) | ||
| else: | ||
| story = await story_service.get_story(story_id=story_id) |
There was a problem hiding this comment.
Suggested change
| story = await story_service.get_story(story_id=story_id) | |
| story = await story_service.get_story(story_id=story_id, current_user=user) |
cloNoey
approved these changes
Jan 20, 2025
MunJaeyoung
approved these changes
Jan 21, 2025
Comment on lines
+141
to
+142
| if story.user_id != user.user_id or highlight.user_id != user.user_id: | ||
| raise StoryPermissionError() |
There was a problem hiding this comment.
스토리를 삭제할 권한이 없다고 나와서 커스텀 에러 새로 정의해도 좋을 것 같아요. StoryPermissionError로 에러 처리되어 있는 부분에서 모두 같은 에러 메세지가 나와요.
- Deleting story removes story from highlight - Removing story with cover image from highlight selects new image from highlight - Removing last story from highlight deletes highlight - Highlight of the same name as the user's existing highlights cannot be created - Same story cannot be added to the same story twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.