Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

최신버전 체크 로직 수정 #114

Merged
merged 2 commits into from
Sep 13, 2024
Merged

최신버전 체크 로직 수정 #114

merged 2 commits into from
Sep 13, 2024

Conversation

eastshine2741
Copy link
Collaborator

문제 원인

  • 최신버전 체크는 SettingViewModel.versionCheck를 BuildConfig.VERSION_NAME과 비교하는 로직인데, LiveData인 versionCheck에 대한 observe가 누락되어있었다
    • -> 서버에서 GET /version/android 응답이 돌아오더라도 이미 onViewCreated 지난 시점이므로 문구가 "최신버전을 이용중입니다"로 갱신되지 않는다

변경사항

  • 누락된 observe 복구

@eastshine2741 eastshine2741 merged commit 002ea2f into develop Sep 13, 2024
2 checks passed
@eastshine2741 eastshine2741 deleted the eastshine2741/fix-version-check branch September 13, 2024 16:11
@eastshine2741 eastshine2741 mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eastshine2741