Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

비밀번호 재설정 regex 수정 #381

Merged
merged 2 commits into from
Jan 4, 2025
Merged

비밀번호 재설정 regex 수정 #381

merged 2 commits into from
Jan 4, 2025

Conversation

plgafhd
Copy link
Collaborator

@plgafhd plgafhd commented Dec 12, 2024

  • 기존 regex가 특수문자를 포함하지 못함
  • 서버에서 사용하는 regex 그대로 사용

@plgafhd plgafhd requested a review from a team as a code owner December 12, 2024 04:43
@plgafhd
Copy link
Collaborator Author

plgafhd commented Dec 12, 2024

사실 서버에서 같은 regex로 체크해주긴 하나...
클라에서 체크하는건 api 요청을 줄이는 의의가 있는건가...?
그런거면 후에 더보기 > 내 계정 > 비밀번호 변경에도 적용하면 괜찮을 것 같아 (현재는 ApiOnError에 감싸져 있을테니 보류...)

@eastshine2741
Copy link
Collaborator

서버에서 검사하는데 클라에서도 해야하는가 의미지?
장점은 api 호출 줄일 수 있고
단점은 나중에 스펙 바뀌면 구클라 대응이 필요하다 같은데
이게 바뀔 일은 없어보여서 괜찮을 듯??

나도 잘 모르겠어

@plgafhd plgafhd enabled auto-merge (squash) January 4, 2025 08:28
@plgafhd plgafhd merged commit b849c9e into develop Jan 4, 2025
3 checks passed
@plgafhd plgafhd deleted the plgafhd/fix-password-regex branch January 4, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastshine2741 eastshine2741 eastshine2741 approved these changes

Assignees

@plgafhd plgafhd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plgafhd @eastshine2741