테마 마켓 추가 #383
Open
테마 마켓 추가 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastshine2741
commented
Dec 15, 2024
| factory = { | ||
| webView | ||
| }, | ||
| modifier = modifier.clipToBounds(), // Compose에서 WebView 사용 시, WebView가 잠깐 동안 다른 Composable을 가리는 WebView 버그 대응(https://issuetracker.google.com/issues/174233728?pli=1#comment5) |
There was a problem hiding this comment.
안드 웹뷰가 그려질 때 잠깐 동안 다른 Composable을 가리는 버그가 있음
Modifier.clipToBounds()를 적용해서 웹뷰가 자신의 bound을 넘어서 그려지지 않도록 강제
https://issuetracker.google.com/issues/174233728?pli=1#comment5
Base automatically changed from
eastshine2741/refactor-custom-theme
to
develop
January 27, 2025 13:03
plgafhd
reviewed
Jan 28, 2025
Comment on lines
+66
to
+71
| @Composable | ||
| fun MarketCustomThemeMoreActionBottomSheet( | ||
| onClickDetail: () -> Unit, | ||
| onClickDelete: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| ) { |
There was a problem hiding this comment.
흐음 혹시 이 MarketCustomThemeMoreActionBottomSheet랑 MyCustomThemeMoreActionBottomSheet 잘 합치는건 별로인가..?
굳이 무리한 합치기이면 필요 없긴 한데 약간 중복 느낌도 있어서
+) 으음 전체적으로 따로따로 있구나 굳이 합칠필요 없는것 같기도
JuTaK97
reviewed
Jan 29, 2025
|
|
||
| @Composable | ||
| fun ThemeMarketScreen( | ||
| accessToken: StateFlow<String>, |
There was a problem hiding this comment.
route 에서 collect 하고 값으로 넘기는 거랑 어떤 차이가 있지? (진짜모름)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#382 의 변경사항 위에서 작업했어요