위젯 다크 모드 추가 #384
Merged
위젯 다크 모드 추가 #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plgafhd
commented
Jan 5, 2025
Comment on lines
+136
to
+142
| val sharedPreferences = context.getSharedPreferences(SNUTTStorage.DOMAIN_SCOPE_CURRENT_VERSION, Context.MODE_PRIVATE) | ||
| val themeMode = sharedPreferences.getString("theme_mode", null) ?: "" | ||
| val isDarkMode = when (themeMode) { | ||
| "\"DARK\"" -> true | ||
| "\"LIGHT\"" -> false | ||
| else -> isSystemDarkMode(context) | ||
| } |
There was a problem hiding this comment.
생각보다 앱 내 화면 모드를 가져오는게 어렵지 않았어
만약 그냥 시스템 모드를 가져오는거로 바꾼다면 저 isSystemDarkMode()만 쓰면 되는 상황
There was a problem hiding this comment.
어 isSystemDarkMode 이거 composable 함수인줄 알았는데 아니었구나 ㅋㅋㅋ 굳굳
Comment on lines
+144
to
+158
| setBackgroundColor( | ||
| if (isDarkMode) Color.rgb(43, 43, 43) else Color.rgb(255, 255, 255), | ||
| ) | ||
| linePaint.apply { | ||
| color = if (isDarkMode) Color.rgb(60, 60, 60) else Color.rgb(235, 235, 235) | ||
| } | ||
| subLinePaint.apply { | ||
| color = if (isDarkMode) Color.rgb(60, 60, 60) else Color.rgb(243, 243, 243) | ||
| } | ||
| hourLabelTextPaint.apply { | ||
| color = if (isDarkMode) Color.rgb(119, 119, 119) else Color.rgb(0, 0, 0) | ||
| } | ||
| dayLabelTextPaint.apply { | ||
| color = if (isDarkMode) Color.rgb(119, 119, 119) else Color.rgb(0, 0, 0) | ||
| } |
There was a problem hiding this comment.
Color... 좀 마음에 안들게 가져오는데 SNUTTColors꺼를 갖다 쓰는게 안되니
개선한다면 그냥 상수로 들고 있다가 가져오는 정도...가 최선일것 같기도 하고...
eastshine2741
approved these changes
Jan 12, 2025
Comment on lines
+139
to
+140
| "\"DARK\"" -> true | ||
| "\"LIGHT\"" -> false |
There was a problem hiding this comment.
오 SharedPreference에 ThemeMode 저장할 때 큰따옴표도 같이 저장돼??
직렬화할 때 MoshiSerializer#serialize() 타는 거 같은데 moshi가 그렇게 동작하는건가
There was a problem hiding this comment.
음 그러게 ThemeMode가 Enum이라 그런가
저장할 때 직렬화를 하는데, getSharedPreferences로 가져와서 그럴까..?
이유는 생각 안해보긴 했어.. ㅋㅋㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.