커스텀 테마 #211
Merged
커스텀 테마 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davin111
requested review from
Hank-Choi,
Jhvictor4 and
subeenpark-io
and removed request for
a team
Hank-Choi
reviewed
Jan 30, 2024
| it.updatedAt = LocalDateTime.now() | ||
| timetableThemeRepository.save(it) | ||
| } else { | ||
| timetableThemeRepository.delete(it) |
Comment on lines
+133
to
+139
| if (theme.isCustom) { | ||
| theme.isDefault = false | ||
| theme.updatedAt = LocalDateTime.now() | ||
| timetableThemeRepository.save(theme) | ||
| } else { | ||
| timetableThemeRepository.delete(theme) | ||
| } |
There was a problem hiding this comment.
얘도 무슨스펙인지 모르겠음
custom이 아니면 왜 지워야하는거지?
There was a problem hiding this comment.
Db 에서 기본 제공 테마(snutt, 가을 같은 거)는 유저가 그걸 자신의 디폴트 테마로 지정했을 때만 존재하도록 해서 만들어진 거야. 굳이 안 지워줘도 되긴 하는데 굳이 잔어물을 남기지 않으려 했음.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존에 존재하던 SNUTT, 가을, 잔디 등의 테마는 BasicThemeType 이라고 칭함
유저가 해당 Basic 테마들을 디폴트 테마로 지정한 경우에만 TimetableTheme 으로 생성함
그 외에 유저는 커스텀 테마들을 생성/수정/삭제/복사할 수 있음. 이 경우에도 TimetableTheme 을 생성함
강의를 추가하면 커스텀 테마인 경우 테마 색상 중 하나를 랜덤으로 택함
특정 시간표의 지정 테마를 바꾸는 경우, 서버가 해당 테마의 색상들로 일괄 순차 채색함
디폴트 테마를 해제하면 SNUTT 테마를 디폴트로 지정함