-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 6.1 and Django 5.0 upgrade #473
Conversation
For Django 5.0 compatability.
No longer required since Wagtail 6.0; see https://docs.wagtail.org/en/stable/releases/6.0.html#streamfield-no-longer-requires-use-json-field-true
These are no longer ModelAdmin classes. Rename to reflect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t tested this locally, yet. I might not get a chance to spin this up with real..ish data and media. But at a glance this looks good to me. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took it for a spin locally. LGTM
we can drop wagtailaltgenerator
- it was used for various demos in the past, but it is not something we actively use at the moment as far as I know. /cc @vossisboss
Great, thanks all! I'll add a commit to drop |
To ensure we can read poetry.lock
Think it would be nice if wagtail.org would run the latest Wagtail and Django. Unless we have reason to stay on long term support versions?
I don't have an up-to-date copy of the database to test if nothing breaks. Hope someone is able to help out with this.
Especially the dependency on
wagtailaltgenerator
is concerning to me as it has seen no updates in about 4 years. I think we should remove it and add alt text manually.