Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.1 and Django 5.0 upgrade #473

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Wagtail 6.1 and Django 5.0 upgrade #473

merged 11 commits into from
Oct 16, 2024

Conversation

Stormheg
Copy link
Member

Think it would be nice if wagtail.org would run the latest Wagtail and Django. Unless we have reason to stay on long term support versions?

I don't have an up-to-date copy of the database to test if nothing breaks. Hope someone is able to help out with this.

Especially the dependency on wagtailaltgenerator is concerning to me as it has seen no updates in about 4 years. I think we should remove it and add alt text manually.

Copy link
Member

@allcaps allcaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@KalobTaulien KalobTaulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t tested this locally, yet. I might not get a chance to spin this up with real..ish data and media. But at a glance this looks good to me. 👍

Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took it for a spin locally. LGTM

we can drop wagtailaltgenerator - it was used for various demos in the past, but it is not something we actively use at the moment as far as I know. /cc @vossisboss

@Stormheg
Copy link
Member Author

Great, thanks all! I'll add a commit to drop wagtailaltgenerator 👍

@vossisboss
Copy link
Contributor

@Stormheg Thanks so much for this! Sorry I didn't see this sooner. @cnk and I caught that the Poetry version needed to be updated in the CI. But otherwise I think we're ready to merge this! 🎉

@vossisboss vossisboss merged commit 9acdc9d into main Oct 16, 2024
3 checks passed
@Stormheg Stormheg deleted the chore/wagtail-61 branch November 20, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants