Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Wash Intro tutorial #8

Merged
merged 46 commits into from
May 4, 2021
Merged

Wash Intro tutorial #8

merged 46 commits into from
May 4, 2021

Conversation

jordan-rash
Copy link
Member

@jordan-rash jordan-rash commented Apr 5, 2021

@jordan-rash jordan-rash marked this pull request as draft April 5, 2021 18:11
@jordan-rash
Copy link
Member Author

jordan-rash commented Apr 19, 2021

Suggested steps

  1. wash overview
  2. start wash (up)
  3. discuss claims
  4. discuss ctl
  5. discuss drain
  6. discuss keys
  7. discuss par
  8. discuss reg

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few requests, all in all this is easy to follow and works well! By the time I finished reading the first part the REPL was ready for me

wasmcloud_basics/wash_intro/intro.md Outdated Show resolved Hide resolved
wasmcloud_basics/wash_intro/start.md Outdated Show resolved Hide resolved
wasmcloud_basics/wash_intro/start.md Outdated Show resolved Hide resolved
wasmcloud_basics/wash_intro/start.md Outdated Show resolved Hide resolved
wasmcloud_basics/wash_intro/claims.md Outdated Show resolved Hide resolved
wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
Copy link
Member

@autodidaddict autodidaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the few minor nitpicks about the use of wasmCloud as a noun, LGTM.

01-wasmcloud_basics-pathway.json Show resolved Hide resolved
01-wasmcloud_basics-pathway.json Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/claims.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/claims.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/finish.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/foreground.sh Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/start.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/start.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/claims.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/ctl.md Outdated Show resolved Hide resolved
01-wasmcloud_basics/wash_intro/finish.md Show resolved Hide resolved
@jordan-rash jordan-rash marked this pull request as ready for review May 3, 2021 22:08
@jordan-rash jordan-rash linked an issue May 3, 2021 that may be closed by this pull request
@jordan-rash jordan-rash changed the title WIP: Wash Intro tutorial Wash Intro tutorial May 3, 2021
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Only other thing, if you could just wait until wash 0.4.4 ends up releasing https://github.com/wasmCloud/wash/actions, that would be awesome as it fixes a key cursor location issue

01-wasmcloud_basics/wash_intro/intro.md Outdated Show resolved Hide resolved
@jordan-rash jordan-rash dismissed autodidaddict’s stale review May 4, 2021 00:38

Remaining changed to to addressed in new PR

@jordan-rash jordan-rash merged commit 5e8a02b into master May 4, 2021
@jordan-rash jordan-rash deleted the wash-intro branch May 4, 2021 00:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create full suite of Katacoda tutorials
4 participants