Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ShellBatched Integrators #127

Merged
merged 5 commits into from
May 21, 2024

Conversation

wavefunction91
Copy link
Owner

Refactor the ShellBatched integrator to be independent of underlying incore integrator. This makes ShellBatched accessible from the host (as will serve as the starting point for distributed memory P/VXC data structures) as well as the existing device implementation.

mikovtun added a commit to mikovtun/GauXC that referenced this pull request May 20, 2024
@wavefunction91 wavefunction91 merged commit b9c2161 into master May 21, 2024
12 checks passed
@wavefunction91 wavefunction91 deleted the refactor/combined-shell-batched branch May 21, 2024 22:55
wavefunction91 pushed a commit that referenced this pull request May 31, 2024
commit 62ac01fab0767f13a7424bcea8a940c92e3aa7e2
Author: David Williams-Young <[email protected]>
Date:   Fri May 31 13:36:46 2024 -0700

    Fix EXC-only path for host integrators, UTs pass

commit 57f305c39ca4c858d5050c5dfc32c3b1ffab2e82
Merge: 1c844b4 92bbbe2
Author: David Williams-Young <[email protected]>
Date:   Fri May 31 12:28:27 2024 -0700

    Merge branch 'master' into merge_master

commit 92bbbe2
Author: David Williams-Young <[email protected]>
Date:   Fri May 31 10:50:04 2024 -0700

    actions/checkout@v3 -> actions/checkout@v4 (#131)

    Bump actions/checkout version to quiet GHA warnings

commit b61ee7a
Author: mikovtun <[email protected]>
Date:   Fri May 31 10:21:21 2024 -0700

    Spellcheck Error Messages (#129)

    * Fixed spelling in error messages and homogenized capitalization

    * Update include/gauxc/load_balancer.hpp

    Co-authored-by: David Williams-Young <[email protected]>

    ---------

    Co-authored-by: David Williams-Young <[email protected]>

commit 905c36a
Author: Ajay Panyala <[email protected]>
Date:   Fri May 31 09:07:08 2024 -0700

    cutlass requires cuda CC >= 8.0 (#130)

commit b9c2161
Author: David Williams-Young <[email protected]>
Date:   Tue May 21 15:13:43 2024 -0700

    Refactor ShellBatched Integrators (#127)

    * Refactor of RKS/UKS/GKS Host drivers to reduce code replication + various QoL

    * ShellBatched Refactor - Host compiles and tests, device untested

    * Fix new ShellBatched for Device, add additional std::future::get to proagate exceptions

    * Update copyright year on old files, shellbatched -> shell_batched

    * document why the extra std::future::get is there

commit 6a8f4bf
Author: David Williams-Young <[email protected]>
Date:   Wed May 8 09:32:51 2024 -0700

    Add Runtime Environment Query Functions (#126)

    * Add runtime environment query functions

    * Update gauxc_config.hpp.in

commit cf6b85c
Author: Ajay Panyala <[email protected]>
Date:   Tue May 7 09:48:17 2024 -0700

    install nccl module file

commit 3e44fcc
Author: David Williams-Young <[email protected]>
Date:   Mon May 6 16:01:48 2024 -0700

    Make CUTLASS a build-only dependency
wavefunction91 added a commit that referenced this pull request May 31, 2024
* Add RKS EXC-only integrator interface + UTs

* Add UKS/GKS EXC-only interfaces

* Make EXC-only path through GPU code work

* Explicitly disable UKS/GKS EXC only

* Update EXC Only with `master`: Squashed commit of the following:

commit 62ac01fab0767f13a7424bcea8a940c92e3aa7e2
Author: David Williams-Young <[email protected]>
Date:   Fri May 31 13:36:46 2024 -0700

    Fix EXC-only path for host integrators, UTs pass

commit 57f305c39ca4c858d5050c5dfc32c3b1ffab2e82
Merge: 1c844b4 92bbbe2
Author: David Williams-Young <[email protected]>
Date:   Fri May 31 12:28:27 2024 -0700

    Merge branch 'master' into merge_master

commit 92bbbe2
Author: David Williams-Young <[email protected]>
Date:   Fri May 31 10:50:04 2024 -0700

    actions/checkout@v3 -> actions/checkout@v4 (#131)

    Bump actions/checkout version to quiet GHA warnings

commit b61ee7a
Author: mikovtun <[email protected]>
Date:   Fri May 31 10:21:21 2024 -0700

    Spellcheck Error Messages (#129)

    * Fixed spelling in error messages and homogenized capitalization

    * Update include/gauxc/load_balancer.hpp

    Co-authored-by: David Williams-Young <[email protected]>

    ---------

    Co-authored-by: David Williams-Young <[email protected]>

commit 905c36a
Author: Ajay Panyala <[email protected]>
Date:   Fri May 31 09:07:08 2024 -0700

    cutlass requires cuda CC >= 8.0 (#130)

commit b9c2161
Author: David Williams-Young <[email protected]>
Date:   Tue May 21 15:13:43 2024 -0700

    Refactor ShellBatched Integrators (#127)

    * Refactor of RKS/UKS/GKS Host drivers to reduce code replication + various QoL

    * ShellBatched Refactor - Host compiles and tests, device untested

    * Fix new ShellBatched for Device, add additional std::future::get to proagate exceptions

    * Update copyright year on old files, shellbatched -> shell_batched

    * document why the extra std::future::get is there

commit 6a8f4bf
Author: David Williams-Young <[email protected]>
Date:   Wed May 8 09:32:51 2024 -0700

    Add Runtime Environment Query Functions (#126)

    * Add runtime environment query functions

    * Update gauxc_config.hpp.in

commit cf6b85c
Author: Ajay Panyala <[email protected]>
Date:   Tue May 7 09:48:17 2024 -0700

    install nccl module file

commit 3e44fcc
Author: David Williams-Young <[email protected]>
Date:   Mon May 6 16:01:48 2024 -0700

    Make CUTLASS a build-only dependency

* Add missing file

* Remove old shellbatched file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant