Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard pointer asserts on null-y-type arguments #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard pointer asserts on null-y-type arguments #19

wants to merge 1 commit into from
+8 −8

Conversation

wavefunction91
Copy link
Owner

Fixes #18

@wavefunction91
Copy link
Owner Author

@tyzhang1993 Can you check that this fixes your problem?

@tyzhang1993
Copy link

It's been some time. I do not have a test case on my hand. The code looks good to me. I'll try to test today and let you know. If I cannot find a good test today. You can go ahead and merge.

@tyzhang1993
Copy link

I cannot find my old test case, but I believe this fix should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion failure on ranks with no computation task
2 participants
@wavefunction91 @tyzhang1993