enhance: disk index support binary vector (milvus-io#33631)

issue:milvus-io#22837 related milvus-io#33575 Signed-off-by: cqy123456 <[email protected]>
wayblink · Jun 5, 2024 · 703fc73 · 703fc73
1 parent 412ccfb
commit 703fc73
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/internal/core/src/index/IndexFactory.cpp b/internal/core/src/index/IndexFactory.cpp
@@ -209,6 +209,10 @@ IndexFactory::CreateVectorIndex(
                 return std::make_unique<VectorDiskAnnIndex<bfloat16>>(
                     index_type, metric_type, version, file_manager_context);
             }
+            case DataType::VECTOR_BINARY: {
+                return std::make_unique<VectorDiskAnnIndex<bin1>>(
+                    index_type, metric_type, version, file_manager_context);
+            }
             default:
                 throw SegcoreError(
                     DataTypeInvalid,
@@ -316,6 +320,14 @@ IndexFactory::CreateVectorIndex(
                     space,
                     file_manager_context);
             }
+            case DataType::VECTOR_BINARY: {
+                return std::make_unique<VectorDiskAnnIndex<bin1>>(
+                    index_type,
+                    metric_type,
+                    version,
+                    space,
+                    file_manager_context);
+            }
             default:
                 throw SegcoreError(
                     DataTypeInvalid,

diff --git a/internal/core/src/index/VectorDiskIndex.cpp b/internal/core/src/index/VectorDiskIndex.cpp
@@ -513,5 +513,6 @@ VectorDiskAnnIndex<T>::update_load_json(const Config& config) {
 template class VectorDiskAnnIndex<float>;
 template class VectorDiskAnnIndex<float16>;
 template class VectorDiskAnnIndex<bfloat16>;
+template class VectorDiskAnnIndex<bin1>;
 
 }  // namespace milvus::index
diff --git a/internal/core/src/storage/DiskFileManagerImpl.cpp b/internal/core/src/storage/DiskFileManagerImpl.cpp
@@ -837,6 +837,9 @@ template std::string
 DiskFileManagerImpl::CacheRawDataToDisk<bfloat16>(
     std::vector<std::string> remote_files);
 template std::string
+DiskFileManagerImpl::CacheRawDataToDisk<bin1>(
+    std::vector<std::string> remote_files);
+template std::string
 DiskFileManagerImpl::CacheRawDataToDisk<float>(
     std::shared_ptr<milvus_storage::Space> space);
 template std::string
@@ -845,5 +848,8 @@ DiskFileManagerImpl::CacheRawDataToDisk<float16>(
 template std::string
 DiskFileManagerImpl::CacheRawDataToDisk<bfloat16>(
     std::shared_ptr<milvus_storage::Space> space);
+template std::string
+DiskFileManagerImpl::CacheRawDataToDisk<bin1>(
+    std::shared_ptr<milvus_storage::Space> space);
 
 }  // namespace milvus::storage