Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added edit/delete/disable buttons to script list #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

s84606
Copy link

@s84606 s84606 commented Aug 27, 2013

Hi, I'm exploring the possibility to integrate your library into:
https://github.com/WaniKani/Android-Notification
which is released according to GPLv3 (hope that's ok for you).

First of all thanks for sharing your code; I had to change some classes, to ease the integration with the app:

  • Added a few buttons to the script list, to perform simple management tasks
  • Added a few more hooks to WebViewGmImpl, in order to keep most code, but instantiate personalized classes
  • Added possibility to choose not to start the integrated browser when WebViewGmImpl is started
  • Added "isEnabled" method to ScriptStore function (I believe this is the only change that can possibly break existing code, in case it has been directly implemented without subclassing ScriptStoreSQLite)
    I think I'll need the @require and @resource tags. If you have already an idea on how to implement them, let me know: if I have some spare time I may try and add them. I was thinking of a separate SQL table referenced by the scripts table (may need a join table too).

Cheers.
Alberto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant