Align flux-dependencies in go.mod #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Around the https://github.com/fluxcd/flux2/blob/v2.0.0-rc.3/go.mod - v2.0.0-rc.3 is the last release that uses controller-runtime 0.14.x - controller-runtime 0.15.0 introduces lots of breaking changes and a dependence on k8s golang 0.27.0
foot
force-pushed
the
align-flux-deps-in-go-mod
branch
from
4409190 to
7fe8991
Compare
yiannistri
reviewed
Jul 6, 2023
yiannistri
approved these changes
Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #3818 which reverts the migration to controller-runtime 0.15.0 for now.
Closes
What changed?
Align all the flux dep versions so they're more or less in sync.
Why was this change made?
Lots of diff deps in flux, want them to be aligned so no funny expected behaviour pops up
How was this change implemented?
Looking up the v2.0.0-rc.3 go.mod and making weave-gitops' go.mod versions as similar as possible
How did you validate the change?
Release notes
Documentation Changes