fix: fix action return value (#56)

* fix: memo connect Hoc * chore: changeset * fix: fix action return value * chore: changeset
web-infra-dev · Jul 24, 2022 · 30b1167 · 30b1167
1 parent 7f178b7
commit 30b1167
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/.changeset/loud-clouds-matter.md b/.changeset/loud-clouds-matter.md
@@ -0,0 +1,5 @@
+---
+'@modern-js-reduck/store': patch
+---
+
+fix: fix action return value
diff --git a/packages/store/src/__test__/onMount.test.ts b/packages/store/src/__test__/onMount.test.ts
@@ -9,12 +9,12 @@ const createCountModel = (onMountCreator: (onMount: any, use: any) => void) =>
         value: 1,
       },
       actions: {
-        addValue(state) {
+        addValue(state, value) {
           return {
             ...state,
             // FIXME: ESlint 校验时，无法正确获取参数 state 的类型信息，识别为 any
             // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
-            value: state.value + 1,
+            value: state.value + value,
           };
         },
       },
@@ -63,12 +63,31 @@ describe('test onMount hook', () => {
 
         expect(state).toEqual({ value: 1 });
 
-        actions.addValue();
+        actions.addValue(1);
 
         expect(use(count)[0]).toEqual({ value: 2 });
       });
     };
     const count = createCountModel(onMountCreator);
     store.use(count);
   });
+
+  test('actions should return correct value', () => {
+    const store = createStore();
+    const onMountCreator = (onMount, use) => {
+      onMount(() => {
+        const [, actions] = use(count);
+
+        const result = actions.addValue(1);
+
+        expect(result).toEqual({
+          type: 'COUNT/ADDVALUE',
+          payload: 1,
+          extraArgs: [],
+        });
+      });
+    };
+    const count = createCountModel(onMountCreator);
+    store.use(count);
+  });
 });
diff --git a/packages/store/src/model/mountModel.ts b/packages/store/src/model/mountModel.ts
@@ -264,7 +264,7 @@ const createDispatchActions = (
 
   forEachAction(modelDesc, path =>
     set(path, (payload: any, ...extraArgs: any[]) => {
-      context.store.dispatch({
+      return context.store.dispatch({
         type: path.join('/').toUpperCase(),
         payload,
         extraArgs,