Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH Pages to 11ty 3 #2316

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Nov 25, 2024

Also noticed Github pages was excluded from Dependabot, so I added it there.

@github-actions github-actions bot added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Nov 25, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, sorry for the late review. I had a pending comment that I just… never submitted. 🤦

import { EleventyHtmlBasePlugin } from "@11ty/eleventy";
import markdownIt from "markdown-it";
import markdownItAnchor from "markdown-it-anchor";
import UpgradeHelper from "@11ty/eleventy-upgrade-help";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the README, it seems like maybe this isn't something we're supposed to keep around? It's also not in the package.json, so I'm thinking that this is maybe unintentionally left over?

Run your usual build command (e.g. npm run build) and pay attention to the output. Address any violations and warnings. Once you’ve removed all of the violations/warnings from your output, run npm uninstall @11ty/eleventy-upgrade-help to remove the plugin and delete its code from your Eleventy configuration file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch- I forgot to clean that up, so I dd that now.

It does bring up that we aren't testing the gh-pages build in PRs, but since that's the minority of PRs, should we?

@jamesnw jamesnw requested a review from ddbeck January 9, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants