-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen Wake Lock: Add test for non-fully active doc #45599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks fine, although it seems to be checking a condition that's already covered by the other ones.
I wonder if it'd be possible to add a test for the new check being added in w3c/screen-wake-lock#367 (i.e. using window_state_context()
to change the page visibility after calling request() and verifying the latter fails).
Yeah, you are right... it's a simplified version of the others as it's just a single iframe. I'm ok to keep it though as it could prove useful in case something goes wrong (easier to debug than the other ones).
Yeah, that's a good idea. However, w3c/screen-wake-lock#367 is just dealing with fully active stuff. We should have another test just for testing visibility. We should do that in separate file though, because otherwise (in webkit at least) we wouldn't be able to run this test on iOS devices, because we can't hide windows/tabs in automation on mobile. |
Filed w3c/screen-wake-lock#373 |
Add test for w3c/screen-wake-lock#367