chore: added more of personal_sign test cases #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
previously approved these changes
Jan 9, 2024
I think I'll add them as a separate PR but based on this branch. |
|
@janndriessen I've decided I'll push related changes regarding these TODOs into this PR. |
Sorry, there were too many changes and now there's a separate PR open that handles these TODOs and even more. See #841 |
JeneaVranceanu
commented
Jan 24, 2024
Comment on lines
+16
to
+20
| // TODO: add the following error message: Missing `attachedKeystoreManager`. | ||
| throw Web3Error.walletError | ||
| } | ||
| guard let ethAddresses = keystoreManager.addresses else { | ||
| // TODO: add the following error message: Missing attached keystore is empty. |
There was a problem hiding this comment.
These TODOs are resolved here: #841
yaroslavyaroslav
approved these changes
Feb 7, 2024
|
@JeneaVranceanu LGTM. It's required a second review though, ping me if you're wishing to force merge it. |
janndriessen
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Based on conversations in Discord support channel I've added more personal_sign test cases as a redundancy.
Test Data or Screenshots
By submitting this pull request, you are confirming the following:
developbranch.