Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneEuroFilter inside the Worker #310

Merged
merged 11 commits into from
Nov 25, 2023
Merged

OneEuroFilter inside the Worker #310

merged 11 commits into from
Nov 25, 2023

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Apr 1, 2023

Running the OEF (OneEuroFilter) inside the Worker may help from a performance point of view.
I will test in this PR also the new OneEuroFilter project.

@kalwalt
Copy link
Member Author

kalwalt commented Nov 21, 2023

With the latest commit, testing the examples, i got this error:
Uncaught TypeError: Cannot destructure property 'ARControllerNFT' of 'I(...)' as it is undefined.
and the app stop of course.
If i revert back to the previous commit all went fine, examples works as usual.

@kalwalt
Copy link
Member Author

kalwalt commented Nov 21, 2023

I need to make a new release of ARnft-threejs without the OneEuroFilter, and push the 1.6.1 jsartoolkitNFT release, i was sure to have done this last but there are no traces... see issue webarkit/jsartoolkitNFT#335 as reminder.

@kalwalt kalwalt self-assigned this Nov 25, 2023
@kalwalt kalwalt merged commit 6fc6a06 into dev Nov 25, 2023
3 checks passed
kalwalt added a commit that referenced this pull request Nov 25, 2023
@kalwalt kalwalt deleted the feature-oef-worker branch November 15, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-design 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant