Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for shader error logs handling on some devices. #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for shader error logs handling on some devices. #2

wants to merge 1 commit into from

Conversation

TheoTheDev
Copy link

@TheoTheDev TheoTheDev commented Jan 27, 2022 •
edited
Loading

Related issue webaverse/app#2284

@avaer
Copy link
Contributor

avaer commented Jan 27, 2022

Does this conflict with the upstream PR? Should we propose in the upstream?

@avaer
Copy link
Contributor

avaer commented Jan 27, 2022 •
edited
Loading

The upstream PR in question: mrdoob/three.js#19752

@avaer
Copy link
Contributor

avaer commented Jan 29, 2022

This should be done in https://github.com/webaverse/three.js and then built to here if needed.

@avaer
Copy link
Contributor

avaer commented Jan 29, 2022

webaverse/three.js#4

@avaer avaer mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheoTheDev @avaer