refactor(plugin-meetings): refactor tests

webex · Jul 11, 2024 · 0f87ce3 · 0f87ce3
1 parent 108356a
commit 0f87ce3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js
@@ -906,12 +906,9 @@ describe('plugin-meetings', () => {
         );
       });
 
-      describe('frame rate reporting in stats analyzer', () => {
-        beforeEach(async () => {
+      it('emits the correct transmittedFrameRate/receivedFrameRate', async () => {
+        it('at the start of the stats analyzer', async () => {
           await startStatsAnalyzer();
-        });
-
-        it('should report a zero frame rate for both transmitted and received video at the start', async () => {
           assert.strictEqual(mqeData.videoTransmit[0].streams[0].common.transmittedFrameRate, 0);
           assert.strictEqual(mqeData.videoReceive[0].streams[0].common.receivedFrameRate, 0);
         });
@@ -1948,7 +1945,7 @@ describe('plugin-meetings', () => {
         })
       })
 
-      it('has correct cpu info about number of cores', async () => {
+      it('reports the number of logical CPU cores', async () => {
         sinon.stub(CpuInfo, 'getNumLogicalCores').returns(12);
         await startStatsAnalyzer({expected: {receiveVideo: true}});
 

diff --git a/yarn.lock b/yarn.lock
@@ -8157,6 +8157,7 @@ __metadata:
     "@webex/test-helper-mock-webex": "workspace:*"
     "@webex/test-helper-retry": "workspace:*"
     "@webex/test-helper-test-users": "workspace:*"
+    "@webex/web-capabilities": 1.3.0
     "@webex/webex-core": "workspace:*"
     ampersand-collection: ^2.0.2
     bowser: ^2.11.0
@@ -8831,6 +8832,15 @@ __metadata:
   languageName: unknown
   linkType: soft
 
+"@webex/web-capabilities@npm:1.3.0, @webex/web-capabilities@npm:^1.3.0":
+  version: 1.3.0
+  resolution: "@webex/web-capabilities@npm:1.3.0"
+  dependencies:
+    bowser: ^2.11.0
+  checksum: 5e35c7d17cfd21762f86e16e2237d6e6c3a7b157e38f3a694ffa8e9003ada423fb85e2eca502dd7cf09560896e33007bbb244d87b04d4344152ab2049b60f812
+  languageName: node
+  linkType: hard
+
 "@webex/web-capabilities@npm:^1.1.0":
   version: 1.2.0
   resolution: "@webex/web-capabilities@npm:1.2.0"
@@ -8840,15 +8850,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@webex/web-capabilities@npm:^1.3.0":
-  version: 1.3.0
-  resolution: "@webex/web-capabilities@npm:1.3.0"
-  dependencies:
-    bowser: ^2.11.0
-  checksum: 5e35c7d17cfd21762f86e16e2237d6e6c3a7b157e38f3a694ffa8e9003ada423fb85e2eca502dd7cf09560896e33007bbb244d87b04d4344152ab2049b60f812
-  languageName: node
-  linkType: hard
-
 "@webex/web-client-media-engine@npm:3.20.4":
   version: 3.20.4
   resolution: "@webex/web-client-media-engine@npm:3.20.4"