feat(wxcc): agent-multi-login-changes #4068

pagour98 · 2025-01-21T07:19:02Z

COMPLETES #<SPARK-601180>

This pull request addresses

This PR enables agent multi-login alert in CC Widgets by making the below changes in CC SDK.

by making the following changes

In config.js file allowMultiLogin boolean flag is set to false, because we don't have to allow multi login similar to CC Desktop.
AGENT_MULTI_LOGIN event has been emitted from SDK side, so that widgets can listen to it.

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

Tested the agent multi login Websocket event by logging in agent multiple times.
Tested the other functionalities to ensure nothing breaks.
Tested SDK by following the CC SDK test plan suite

Vidcast for the SDK Changes Testing:- https://app.vidcast.io/share/5ad06894-3ead-40db-8441-e4739e4569d3

I certified that

I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

coderabbitai · 2025-01-21T07:19:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…-login

pagour98 · 2025-01-21T08:10:10Z

packages/@webex/plugin-cc/src/config.ts

@@ -2,7 +2,7 @@ import {LOGGER} from '@webex/calling';

 export default {
  cc: {
-    allowMultiLogin: true,
+    allowMultiLogin: false,


I have tried to set allowMultiLogin to false in webexConfig object inside CC Widgets but that we not working, So I think we need to set allowMultiLogin to false from SDK side

It should work. Approving the PR as still we can debug/test this with false also.

Is there a TODO to fix this?

Also, why do we need this change?

@mkesavan13 , We need this because to tell backend that there should not be multi-login by agent and if there is a multi-login then send AGENT_MULTI_LOGIN event to the client, so that the client know that there is a multi-login.

This will not impact any existing functionality.

mkesavan13

Please add the tests enumerated in the PR description as well as a demo vidcast

rsarika · 2025-01-21T08:29:57Z

packages/@webex/plugin-cc/src/config.ts

@@ -2,7 +2,7 @@ import {LOGGER} from '@webex/calling';

 export default {
  cc: {
-    allowMultiLogin: true,
+    allowMultiLogin: false,


It should work. Approving the PR as still we can debug/test this with false also.

pagour98 · 2025-01-21T10:17:14Z

Please add the tests enumerated in the PR description as well as a demo vidcast

@mkesavan13 , Updated the PR description and added Vidcast for the same.

rarajes2 · 2025-01-22T04:06:04Z

@pagour98 Let's update the SDK samples to show some notification on the UI for multi-login instead of showing in the console. Let's discuss 1-1 if help/clarification is needed.

mkesavan13

I'd like to know how the flow would look in the Widgets like, after this PR is merged. What SDK method do we call once they confirm? How does the other page get logged out?

mkesavan13 · 2025-01-22T04:43:31Z

packages/@webex/plugin-cc/src/config.ts

@@ -2,7 +2,7 @@ import {LOGGER} from '@webex/calling';

 export default {
  cc: {
-    allowMultiLogin: true,
+    allowMultiLogin: false,


Is there a TODO to fix this?

mkesavan13 · 2025-01-22T04:48:47Z

packages/@webex/plugin-cc/src/config.ts

@@ -2,7 +2,7 @@ import {LOGGER} from '@webex/calling';

 export default {
  cc: {
-    allowMultiLogin: true,
+    allowMultiLogin: false,


Also, why do we need this change?

pagour98 · 2025-01-22T07:13:32Z

@pagour98 Let's update the SDK samples to show some notification on the UI for multi-login instead of showing in the console. Let's discuss 1-1 if help/clarification is needed.

@rarajes2 , PR has been updated to show notification on samples page when there is agent multi login

pagour98 · 2025-01-22T12:08:03Z

I'd like to know how the flow would look in the Widgets like, after this PR is merged. What SDK method do we call once they confirm? How does the other page get logged out?

So when we set multilogin to false in sdk, then the server will send the AGENT_MULTI_LOGIN event. If the agent log in second time then the client will receive the event the above event and if the event is received on the existing session we show the alert dialog box and if the confirm is pressed we do web-socket registration again because in case of AGENT_MULTI_LOGIN event the server close down the existing web socket connection. When the agent sigin in new tab, agent-relogin method is called which silently login the agent in new session and the existing session will receive AGENT_MULTI_LOGIN EVENT

pagour98 · 2025-01-22T12:10:31Z

feat(wxcc): agent-multi-login

1628452

pagour98 requested a review from a team as a code owner January 21, 2025 07:19

parv_gour added 5 commits January 21, 2025 13:07

feat(wxcc): added-test-cases

591b7f8

feat(wxcc): fix-allow-multi-login-test-case

b7941fc

Merge branch 'wxcc' of github.com:webex/webex-js-sdk into agent-multi…

b6601a4

…-login

feat(wxcc): fix-allow-multi-login-test-case

be17f54

feat(wxcc): remove-local-debug-stuff

2833140

pagour98 commented Jan 21, 2025

View reviewed changes

pagour98 requested a review from rsarika January 21, 2025 08:14

mkesavan13 requested changes Jan 21, 2025

View reviewed changes

rsarika approved these changes Jan 21, 2025

View reviewed changes

rsarika added the validated If the pull request is validated for automation. label Jan 21, 2025

pagour98 requested a review from mkesavan13 January 21, 2025 10:17

Merge branch 'wxcc' into agent-multi-login

b1c9fee

rsarika self-requested a review January 22, 2025 04:41

mkesavan13 reviewed Jan 22, 2025

View reviewed changes

parv_gour added 3 commits January 22, 2025 11:48

feat(cc-widget): added sample UI alert

0c421cf

feat(cc-widget): latest pull and resolve merge conflicts

382567b

feat(cc-widget): latest pull and resolve merge conflicts

1f49cd9

rsarika approved these changes Jan 22, 2025

View reviewed changes

pagour98 requested a review from mkesavan13 January 22, 2025 12:10

mkesavan13 approved these changes Jan 22, 2025

View reviewed changes

pagour98 merged commit 51cdbdb into wxcc Jan 22, 2025
12 checks passed

pagour98 deleted the agent-multi-login branch January 22, 2025 12:16

pagour98 mentioned this pull request Jan 28, 2025

feat(cc-widgets): added Agent-Multi-Login-Alert Feature webex/widgets#364

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wxcc): agent-multi-login-changes #4068

feat(wxcc): agent-multi-login-changes #4068

pagour98 commented Jan 21, 2025 •

edited

Loading

coderabbitai bot commented Jan 21, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

pagour98 Jan 21, 2025

rsarika Jan 21, 2025

mkesavan13 Jan 22, 2025

mkesavan13 Jan 22, 2025

pagour98 Jan 22, 2025 •

edited

Loading

mkesavan13 left a comment

rsarika Jan 21, 2025

pagour98 commented Jan 21, 2025

rarajes2 commented Jan 22, 2025

mkesavan13 left a comment

mkesavan13 Jan 22, 2025

mkesavan13 Jan 22, 2025

pagour98 commented Jan 22, 2025

pagour98 commented Jan 22, 2025

pagour98 commented Jan 22, 2025

COMPLETES #<SPARK-601180>

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

I certified that

feat(wxcc): agent-multi-login-changes #4068

feat(wxcc): agent-multi-login-changes #4068

Conversation

pagour98 commented Jan 21, 2025 • edited Loading

COMPLETES #<SPARK-601180>

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

I certified that

coderabbitai bot commented Jan 21, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

pagour98 Jan 21, 2025

Choose a reason for hiding this comment

rsarika Jan 21, 2025

Choose a reason for hiding this comment

mkesavan13 Jan 22, 2025

Choose a reason for hiding this comment

mkesavan13 Jan 22, 2025

Choose a reason for hiding this comment

pagour98 Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

mkesavan13 left a comment

Choose a reason for hiding this comment

rsarika Jan 21, 2025

Choose a reason for hiding this comment

pagour98 commented Jan 21, 2025

rarajes2 commented Jan 22, 2025

mkesavan13 left a comment

Choose a reason for hiding this comment

mkesavan13 Jan 22, 2025

Choose a reason for hiding this comment

mkesavan13 Jan 22, 2025

Choose a reason for hiding this comment

pagour98 commented Jan 22, 2025

pagour98 commented Jan 22, 2025

pagour98 commented Jan 22, 2025

COMPLETES #<SPARK-601180>

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

I certified that

pagour98 commented Jan 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pagour98 Jan 22, 2025 •

edited

Loading