fix(cc-sdk): fixed-relogin-issue #4078
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
| @@ -395,6 +399,7 @@ export default class ContactCenter extends WebexPlugin implements IContactCenter | |||
| }); | |||
| throw new Error(`Unsupported device type: ${deviceType}`); | |||
| } | |||
| this.webCallingService.setLoginOption(deviceType); | |||
There was a problem hiding this comment.
Need to do this so we can get calls again in the sample app. Based on this we emit the events.
packages/@webex/plugin-cc/src/cc.ts
Outdated
| // To handle re-registration of event listeners on silent relogin | ||
| this.incomingTaskListener(); | ||
| this.taskManager.registerIncomingCallEvent(); | ||
|
|
||
| await this.handleDeviceType(deviceType as LoginOption, dn); | ||
| this.agentConfig.isAgentLoggedIn = true; | ||
| this.services.webSocketManager.on('message', this.handleWebSocketMessage); |
There was a problem hiding this comment.
The changes looks good. Is it possible to move this line up before setAgentState so the statechange event will be triggered in widgets for re-login
There was a problem hiding this comment.
I think it will resolve the available state issue in widgets
There was a problem hiding this comment.
I don't think it worked Ravi... reason is when we login we don't get the change event always, only if we were available and the internet disconnected - the agent state issue would be something else... we can debug that on the widgets side tho.
COMPLETES #< SPARK-604350 >
This pull request addresses
by making the following changes
Vidcast - https://app.vidcast.io/share/3bf01944-75f8-45f2-8592-3393519b8c43
Change Type
The following scenarios were tested
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.