feat: set/create events #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycetham
reviewed
Feb 8, 2024
|
I think we should consider here what the native events look like and think about being consistent: the real events don't fire an event with the SDP on |
brycetham
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Looks good! Just one small comment on the unit tests.
Also, for completeness, maybe we should add an event for createAnswerOnSuccess too. We don't use that API much but we might as well add it while we're working on these other events.
Let's also update the PR description to reflect your recent changes, in case we want to refer back to this PR in the future.
brycetham
approved these changes
Feb 14, 2024
bbaldino
pushed a commit
that referenced
this pull request
Feb 14, 2024
# [2.5.0](v2.4.0...v2.5.0) (2024-02-14) ### Features * set/create events ([#71](#71)) ([92e01d9](92e01d9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added events that will be called on success operations on offer/answer/description
This includes
CreateOfferOnSuccess- whencreateOffersucceededCreateAnswerOnSuccess- whencreateAnswersucceededSetLocalDescriptionOnSuccess- whensetLocalDescriptionsucceededSetRemoteDescriptionOnSuccess- whensetRemoteDescriptionsucceeded