Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update typescript version #81

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: update typescript version #81

merged 2 commits into from
Jul 10, 2024

Conversation

k-wasniowski
Copy link
Contributor

This PR updates the typescript version. It's needed to be able to use directly RTCPeerConnectionIceErrorEvent which is not available in current typescript version.

Typescript options suppressImplicitAnyIndexErrors is getting deprecated. It's removal causes not being able to compile because suppressLocalAudioPlayback is not defined for MediaTrackConstraints.
suppressLocalAudioPlayback is experimental, thus it's not in typescript yet.

Are we safe to remove this flag from constraints or we should add an typescript option which will supress deprecation of suppressImplicitAnyIndexErrors.

@k-wasniowski k-wasniowski force-pushed the feat-update-typescript-version branch from 9b05fe3 to 95040c4 Compare June 27, 2024 14:39
@k-wasniowski k-wasniowski marked this pull request as ready for review June 27, 2024 15:01
@bbaldino
Copy link
Collaborator

I don't remember there being a specific reason for including suppressLocalAudioPlayback, I'm guessing it was copied over just as a result of including 'all' options that were possible there, so I think it should be ok to yank it? cc @brycetham

@k-wasniowski
Copy link
Contributor Author

I don't remember there being a specific reason for including suppressLocalAudioPlayback, I'm guessing it was copied over just as a result of including 'all' options that were possible there, so I think it should be ok to yank it? cc @brycetham

I did a quick search for it over JS-SDK/Web App and I have not found any usage of it.

@brycetham
Copy link
Contributor

Yeah I say we can get rid of suppressLocalAudioPlayback. We'll eventually want to allow any constraints to be applied instead of a predefined list anyways (see WEBEX-386305).

brycetham
brycetham reviewed Jun 28, 2024
View reviewed changes
package.json Outdated
@@ -72,7 +72,7 @@
"semantic-release": "^19.0.2",
"ts-jest": "^27.0.5",
"ts-loader": "^9.2.3",
"typescript": "^4.4.3",
"typescript": "5.5.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the ^?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it back.

@k-wasniowski k-wasniowski merged commit afa2589 into main Jul 10, 2024
1 check passed
@k-wasniowski k-wasniowski deleted the feat-update-typescript-version branch July 10, 2024 17:20
bbaldino pushed a commit that referenced this pull request Jul 10, 2024
@semantic-release-bot
chore(release): 2.9.0 [skip ci]
6acf5d7 
# [2.9.0](v2.8.0...v2.9.0) (2024-07-10)

### Features

* update typescript version ([#81](#81)) ([afa2589](afa2589))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycetham brycetham brycetham approved these changes

@bbaldino bbaldino Awaiting requested review from bbaldino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-wasniowski @bbaldino @brycetham