Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for forseen type system #189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Prepare for forseen type system #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f4a932
Prepare for forseen type system
hejny Dec 12, 2024
44b925c
Merge branch 'main' into feature/type-system
hejny Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,15 @@ Implicit formfactors
- You don't need to specify the formfactor or input+output params explicitly. Implementing the formfactor interface is sufficient.
- Fix in deep cloning of arrays

### In pre-release

### `0.!!!.0` _(2024-12-)_

Parameter types to establish forseen [type system](https://github.com/webgptorg/book/tree/main/pips/pip-0002)

- Move `expectations` and `format` from `Task` to `Parameter` <!-- <- TODO: !!!!!! -->
- Implicit formfactors - no need to explicitly define them, they are inferred from the pipeline interface <!-- <- TODO: !!!!!! -->

## Drafts

### `0..0` _(2024--)_
Expand Down
22 changes: 12 additions & 10 deletions src/pipeline/PipelineJson/CommonTaskJson.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import type { ForeachJson } from '../../commands/FOREACH/ForeachJson';
import type { FormatCommand } from '../../commands/FORMAT/FormatCommand';
import type { SectionType } from '../../types/SectionType';
import type { string_javascript } from '../../types/typeAliases';
import type { string_markdown } from '../../types/typeAliases';
import type { string_markdown_text } from '../../types/typeAliases';
import type { string_name } from '../../types/typeAliases';
import type { string_parameter_name } from '../../types/typeAliases';
import type { string_postprocessing_function_name } from '../../types/typeAliases';
import type { string_prompt } from '../../types/typeAliases';
import type { string_template } from '../../types/typeAliases';
import { TaskType } from '../../types/TaskType';
import type {
string_javascript,
string_markdown,
string_markdown_text,
string_name,
string_parameter_name,
string_postprocessing_function_name,
string_prompt,
string_template,
} from '../../types/typeAliases';
import type { Expectations } from './Expectations';

/**
Expand Down Expand Up @@ -60,7 +62,7 @@ export type CommonTaskJson = {
* Type of the execution
* This determines if the task is send to LLM, user or some scripting evaluation
*/
readonly taskType: SectionType;
readonly taskType: TaskType;

/**
* Content of the task with {placeholders} for parameters
Expand Down
Loading