Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semester status filtering to BDB #3725

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add semester status filtering to BDB #3725

wants to merge 10 commits into from

Conversation

Bestem0r
Copy link
Contributor

@Bestem0r Bestem0r commented Feb 3, 2025

Description

Adds inline filtering to semester statuses in BDB Pro. Choosing multiple filters works as or on the semester statuses.

Front end PR

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Screencast.From.2025-02-03.17-38-01.mp4

Testing

  • I have thoroughly tested my changes.

Resolves ABA-1048

@Bestem0r Bestem0r requested a review from ivarnakken February 3, 2025 16:52
Copy link

linear bot commented Feb 3, 2025

@Bestem0r Bestem0r requested a review from eikhr February 4, 2025 11:24
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (36170fa) to head (b186b0b).

Files with missing lines Patch % Lines
lego/apps/companies/filters.py 36.36% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
- Coverage   89.69%   89.64%   -0.06%     
==========================================
  Files         707      707              
  Lines       22651    22673      +22     
==========================================
+ Hits        20317    20325       +8     
- Misses       2334     2348      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some tests would be nice tho

Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 📈📈📈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants