Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cmake files from datadir to libdir #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eclipseo
Copy link
Contributor

Current location is preventing me to detect it correctly.

Copy link
Contributor

@jzern jzern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either path will work [1] and there's nothing architecture specific in the file. Did you run into an issue with the existing path?

[1] https://cmake.org/cmake/help/v3.19/command/find_package.html#search-procedure

@eclipseo
Copy link
Contributor Author

It might be specific to my build setup: I use RPM to build a package and it detects the cmake folder automatically in lib64/cmake and thus adds an automatic Provides: cmake(nameofthelibrary) to be called from other packages depending on it. But it does not work in /usr/share. This is pretty distribution specific so I can keep my patch downstream and close this PR if it's ok.

@jzern
Copy link
Contributor

jzern commented May 21, 2021

Thanks for the background. It looks like there isn't a canonical location for these though the cmake docs use lib/ in their current examples [1]. Out of curiosity do any of the other forms work like changing sjpeg/cmake to cmake/sjpeg under /usr/share?

[1] https://cmake.org/cmake/help/v3.20/manual/cmake-packages.7.html?highlight=configpackagelocation#creating-packages

@eclipseo
Copy link
Contributor Author

I've tested cmake/sjpeg under /usr/share and it works. I don't know the list or all working pattern, nor how they are detected by RPM.

@jzern
Copy link
Contributor

jzern commented May 22, 2021

Thanks for trying it out. I'll let Pascal comment, but staying with /usr/share is fine to me.

@skal65535
Copy link
Collaborator

thanks for trying both solutions. If they are both working and allowed, let's just keep it as is, to minimize disruption!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants