-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoD 2021] Improved contributing guidelines #1276
Conversation
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
You haven't attached all the ss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should also add some guidelines about adding relevant labels regarding the PRs and Issues.
We probably can also add the |
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could talk about the style more, but as in my previous experience and Google standards, we are actually trying to eliminate using "you" in documents to make the tone soften and formal. I understand that each document has its own writing style and those Django used don't necessarily apply to Wechaty's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing my suggestion : )
Fixes: #1111
Related: #1012 wechaty/grpc#140 wechaty/openapi#16