Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoD 2021] Improved contributing guidelines #1276

Merged
merged 15 commits into from
Sep 18, 2021
Merged

[GSoD 2021] Improved contributing guidelines #1276

merged 15 commits into from
Sep 18, 2021

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Sep 9, 2021

Signed-off-by: Rajiv Ranjan Singh <[email protected]>
@iamrajiv iamrajiv requested a review from a team as a code owner September 9, 2021 19:02
@Rohitesh-Kumar-Jain
Copy link
Contributor

You haven't attached all the ss

Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should also add some guidelines about adding relevant labels regarding the PRs and Issues.

@Rohitesh-Kumar-Jain
Copy link
Contributor

We probably can also add the Code of Conduct and Getting Help sections in which include a link to the Wechaty Gitter channel as well.

@iamrajiv iamrajiv requested a review from a team as a code owner September 11, 2021 00:24
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could talk about the style more, but as in my previous experience and Google standards, we are actually trying to eliminate using "you" in documents to make the tone soften and formal. I understand that each document has its own writing style and those Django used don't necessarily apply to Wechaty's.

docusaurus/docs/contributing/documentation.md Outdated Show resolved Hide resolved
docusaurus/docs/contributing/documentation.md Outdated Show resolved Hide resolved
docusaurus/docs/contributing/documentation.md Show resolved Hide resolved
docusaurus/docs/contributing/documentation.md Outdated Show resolved Hide resolved
docusaurus/docs/contributing/documentation.md Show resolved Hide resolved
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my suggestion : )

@shraddhavp shraddhavp self-requested a review September 18, 2021 16:43
@iamrajiv iamrajiv merged commit 42a9fd2 into wechaty:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine all of the contribution guide together
5 participants