Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sales-Assistant-Final PR #1477

Merged
merged 66 commits into from
Feb 20, 2022
Merged

Sales-Assistant-Final PR #1477

merged 66 commits into from
Feb 20, 2022

Conversation

KevinTung
Copy link
Contributor

Please make sure to check the following boxes creating your pull request, thank you very much!

  • [ x] Add Blog Header, including title, author, image, categories, tags, etc.

    For example:

    ---
    title: Your Great Blog Title
    author: your_github_id
    categories: project
    tags:
      - python
      - padlocal
    image: /assets/2021/02-your-blog-slug/teaser.jpg
    ---
    
    One line bio
    
    Your blog post content Your blog post content
    Your blog post content Your blog post content
    Your blog post content Your blog post content

    It will be easier to start drafting your post by using a existing post file as your template, for example, this one

  • [ x] Keep all filenames lowercase, and use - to connect words instead of space. e.g. 2017-10-06-wechat-pc-impactor.md instead of 2017-10-06-WeChat PC Impactor.md

  • [ x] Embed video/pdf from YouTube/Bilibili/local (if there's any) by using {% include iframe.html src="URL_or_PATH" %}. (Learn more about how to embed file/url in the post by reading this blog post

  • [x ] Save photo to local before publishing, to a folder named by ${MONTH}-${YOUR_BLOG_SLUG}/ under /assets/2021/ directory.

  • [ x] Select a beautiful and meaningful teaser image for your blog

  • [x ] Create your contributor profile (if you are a first time contributor)

    For excample:

    jekyll/_contributors/lijiarui.md

    ---
    name: Jiarui LI (李佳芮)
    site: https://lijiarui.github.io
    bio: 句子互动创始人 & CEO,微软人工智能最具价值专家 (AI MVP)
    avatar: /jekyll/assets/contributors/lijiarui/avatar.png
    email: [email protected]
    twitter: https://weibo.com/u/2175505900
    ---

    Here is the example file:

To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/

qhduan
qhduan previously approved these changes Feb 12, 2022
@KevinTung
Copy link
Contributor Author

KevinTung commented Feb 12, 2022 via email

@KevinTung
Copy link
Contributor Author

@qhduan @lijiarui @huan 請幫我 approve 一下,謝謝

@@ -74,5 +74,10 @@
"scripts": {
"pre-push": "npx git-scripts-pre-push"
}
},
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not add any irrelevant files in this PR.

I don't think we should add other packages when we add a blog. So please remove this file, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wechaty/wechaty.js.org/issues/1478
there is a dependency issue in wechaty.org.js recently, so this modification is necessary

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Cheers!

@KevinTung
Copy link
Contributor Author

@huan:
Hi! Please have a review on my project, really appreciate it!

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for your great work, I hope this project can be open-sourced and can be keeping improving in the future!

@lijiarui lijiarui enabled auto-merge (squash) February 20, 2022 14:14
@lijiarui lijiarui disabled auto-merge February 20, 2022 14:14
@lijiarui lijiarui merged commit 17e4b7c into wechaty:main Feb 20, 2022
@lijiarui
Copy link
Member

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited KevinTung to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add my: wechat: ruirui_0914 and send this pr link to me. I will invite you into Wechaty Contributor Room

Link to wechaty/PMC#16

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants