-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sales-Assistant-Final PR #1477
Sales-Assistant-Final PR #1477
Conversation
deleted dependencies
Hi 高宇:
I resolved a ependency issue and passed the CI/CD. Please help me approve
this blog again. Really appreciate it!
https://github.com/wechaty/wechaty.js.org/pull/1477
Bests, Kevin Tung
…On Sat, Feb 12, 2022 at 8:12 AM 高宇 ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<https://github.com/wechaty/wechaty.js.org/pull/1477#pullrequestreview-880783619>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6Y27NCFYO6WU3KLGBYTVDU2WQWNANCNFSM5OFE5ZIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@@ -74,5 +74,10 @@ | |||
"scripts": { | |||
"pre-push": "npx git-scripts-pre-push" | |||
} | |||
}, | |||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not add any irrelevant files in this PR.
I don't think we should add other packages when we add a blog. So please remove this file, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/wechaty/wechaty.js.org/issues/1478
there is a dependency issue in wechaty.org.js recently, so this modification is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Cheers!
@huan: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for your great work, I hope this project can be open-sourced and can be keeping improving in the future!
Thank you very much for your contribution! You are welcome to join Wechaty Contributor Program1. Join Wechaty Organization
I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. 2. Update Your Wechaty Contributor Profile
3. Join The Contributor Only WeChat RoomWe also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested. Please add my: wechat: ruirui_0914 and send this pr link to me. I will invite you into Wechaty Contributor Room Link to wechaty/PMC#16 Cheers! |
Please make sure to check the following boxes creating your pull request, thank you very much!
[ x] Add Blog Header, including title, author, image, categories, tags, etc.
For example:
[ x] Keep all filenames lowercase, and use
-
to connect words instead of space. e.g.2017-10-06-wechat-pc-impactor.md
instead of2017-10-06-WeChat PC Impactor.md
[ x] Embed video/pdf from YouTube/Bilibili/local (if there's any) by using
{% include iframe.html src="URL_or_PATH" %}
. (Learn more about how to embed file/url in the post by reading this blog post[x ] Save photo to local before publishing, to a folder named by
${MONTH}-${YOUR_BLOG_SLUG}/
under/assets/2021/
directory.[ x] Select a beautiful and meaningful teaser image for your blog
[x ] Create your contributor profile (if you are a first time contributor)
For excample:
Here is the example file:
To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/