-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chris GSOD2021 #825
Chris GSOD2021 #825
Conversation
Note: <Ongoing Progress>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking forward to seeing your PR to be ready for reviewing!
Hi @chris-4444 is the PR ready to be merged or you would like to push few more commits? |
no more commits, since my new proposal was the joint proposal with joseph. ty @Rohitesh-Kumar-Jain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huan PR is ready to get merged.
@@ -0,0 +1,5 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it's too simple..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As profile request:
-
Keep all filenames lowercase, and use
-
to connect words instead of space. e.g.2017-10-06-wechat-pc-impactor.md
instead of2017-10-06-WeChat PC Impactor.md
-
Create your contributor profile (if you are a first time contributor)
-
Add avatar for your contributor profile
For excample:
jekyll/_contributors/lijiarui.md
--- name: Jiarui LI (李佳芮) site: https://lijiarui.github.io bio: 句子互动创始人 & CEO,微软人工智能最具价值专家 (AI MVP) avatar: /jekyll/assets/contributors/lijiarui/avatar.png email: [email protected] twitter: https://weibo.com/u/2175505900 ---
@chris-4444 either work upon this, or close this : ) |
ping @chris-4444 We will close this PR if there has no more commits send to it before the end of Sep. |
1 similar comment
ping @chris-4444 We will close this PR if there has no more commits send to it before the end of Sep. |
ping @chris-4444 I will close this PR tomorrow if there has no more commits send to it. |
No worries, we can close this PR. I was creating my own proposal and then, came the joint proposal after the Wechaty meeting, just before the final TW selection. Ty. 😎 |
Note:
Please make sure to check the following boxes creating your pull request, thank you very much!
Add Blog Header, including title, author, image, categories, tags, etc.
For example:
Keep all filenames lowercase, and use
-
to connect words instead of space. e.g.2017-10-06-wechat-pc-impactor.md
instead of2017-10-06-WeChat PC Impactor.md
Embed video/pdf from YouTube/Bilibili/local (if there's any) by using
{% include iframe.html src="URL_or_PATH" %}
. (Learn more about how to embed file/url in the post by reading this blog postSave photo to local before publishing, to a folder named by
${MONTH}-${YOUR_BLOG_SLUG}/
under/assets/2021/
directory.Select a beautiful and meaningful teaser image for your blog
Create your contributor profile (if you are a first time contributor)
For excample:
Here is the example file:
To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/