[GSoD 2021] Added Progressive Web Application (PWA) support for the Docusaurus site #910
Conversation
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
There was a problem hiding this comment.
Hi, @iamrajiv thanks for solving the #708 issues, great work.
But I am afraid this ain't related to GSoD 2021? There's probably nothing for @proudofsimin to review in this PR I guess?
It's great that you are working apart from your technical writing duties, please continue doing this if you can. But at the same time, I would like to request that you please first prioritize the deliverables that you proposed in your proposal, and I see you probably are lacking behind.
You are a good programmer I see, so I would like to suggest that you keep working on programming tasks in Wechaty and maybe even participate in Google Summer of Code next year from Wechaty! But please deliver your deliverables as per your current project proposal on time.
I don't see how this task is related to GSoD'21 and your project so you may remove the GSoD'21 label from it, but please add all this extra work in your final project report and as a volunteer, I will give you extra points for all the extra work you are doing for the org.
as for the review, I don't think I and even @proudofsimin are the best people for reviewing it, this should be reviewed by a senior developer I believe.
|
Thanks for letting me know : )
I wasn't expecting this in GSoD, that's quite a maverick way to improve docs, but it's great to have some like you in the team! |
|
Thanks @Rohitesh-Kumar-Jain and @iamrajiv. I guess I will skill this non-doc PR. |
iamrajiv
changed the title
iamrajiv
changed the title
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
|
@iamrajiv You can count me in as your team member, and I have already approved. :) |
Fixes: #708
Related: #1012