Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friend request #981

Merged
merged 37 commits into from
Nov 20, 2021
Merged

Friend request #981

merged 37 commits into from
Nov 20, 2021

Conversation

abhishek-iiit
Copy link
Member

@abhishek-iiit abhishek-iiit commented Jun 27, 2021 •
edited
Loading

Send and accept friend requests

Screenshot from 2021-07-25 08-04-41
Screenshot from 2021-07-25 08-04-50

@abhishek-iiit abhishek-iiit requested a review from a team as a code owner June 27, 2021 11:43
@abhishek-iiit abhishek-iiit self-assigned this Jun 27, 2021
@abhishek-iiit abhishek-iiit added GSoD 2021 how to guide PR related to How-to-Guide section labels Jun 27, 2021
@abhishek-iiit abhishek-iiit linked an issue Jun 27, 2021 that may be closed by this pull request
Update and enhance how-to-guide section #896
Closed
21 tasks
Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Jun 27, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like you have got comfortable with git, quickly learned version control 🎉

@abhishek-iiit
Copy link
Member Author

Thank you for always being there @Rohitesh-Kumar-Jain 😃

@proudofsimin
Copy link
Contributor

not sure if you're waiting but please give me one more day for this PR. Thanks.

proudofsimin
proudofsimin reviewed Jun 30, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this and your previous PR, originally I was expected to see you introduce a bit about the code snippets. You revision is very great, but it would be better if you could explain a bit more about the codes (although they are quite self-explanatory). You could see a great example in JavaScript. I would like to hear your opinion and how you think could make this document better. Please feel free to contact me through email or other. Thank you.

docusaurus/docs/howto/friendship.md Outdated Show resolved Hide resolved
docusaurus/docs/howto/friendship.md Outdated Show resolved Hide resolved
@proudofsimin proudofsimin mentioned this pull request Jul 4, 2021
Merged
@lijiarui
Copy link
Member

Hi @abhishek-iiit , As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@lijiarui
Copy link
Member

Since the .webp format has lots of advantages and the safari has supported it last year which means all the modern browsers will be able to compatible with it.

@huan has just added a new unit test for enforcing the image format: the CI will not be passed if we are using other image formats than the perfect .webp.

Please make CI green to adjust the new rule, see https://github.com/wechaty/wechaty.js.org/issues/1035

vasvi-sood
vasvi-sood requested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@vasvi-sood vasvi-sood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the Image format, because the tests are failing.

vasvi-sood
vasvi-sood reviewed Jul 21, 2021
View reviewed changes
docusaurus/docs/howto/friendship.md Outdated

See [Running our first ding-dong bot](https://wechaty.js.org/docs/getting-started/quick-start).

The below function needs a basic scipt that can help run the bot. The basic script starts by importing the code from [Github/Friend-Bot](https://github.com/wechaty/wechaty/blob/1523c5e02be46ebe2cc172a744b2fbe53351540e/examples/friend-bot.ts).Integrate the below code, for this action to work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the spelling of script.

@abhishek-iiit abhishek-iiit requested a review from vasvi-sood July 25, 2021 02:46
@abhishek-iiit abhishek-iiit requested a review from huan September 16, 2021 20:41
@abhishek-iiit
Copy link
Member Author

@huan I request to look for the approval, so that we can continue towards merging this PR

lijiarui
lijiarui requested changes Sep 18, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishek-iiit I think since you are using an outdated example, please change all of the content to the latest example: https://github.com/wechaty/wechaty-getting-started/blob/main/examples/advanced/friend-bot.js

docusaurus/docs/howto/friendship.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/friendship.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/friendship.mdx Outdated Show resolved Hide resolved
@abhishek-iiit
Copy link
Member Author

@huan @lijiarui I request to look for the approval, so that we can continue towards merging this PR

lijiarui
lijiarui previously requested changes Oct 17, 2021
View reviewed changes
docusaurus/docs/howto/friendship.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/friendship.mdx Outdated Show resolved Hide resolved
docusaurus/docs/howto/friendship.mdx Outdated Show resolved Hide resolved
@shraddhavp shraddhavp self-requested a review November 14, 2021 03:56
shraddhavp
shraddhavp approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@shraddhavp shraddhavp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

huan
huan approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shraddhavp shraddhavp disabled auto-merge November 20, 2021 04:41
@shraddhavp shraddhavp dismissed lijiarui’s stale review November 20, 2021 04:42

the changes told by reviewer is done and approved

@shraddhavp shraddhavp merged commit 128a469 into wechaty:main Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasvi-sood vasvi-sood vasvi-sood approved these changes

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@shraddhavp shraddhavp shraddhavp approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@huan huan huan approved these changes

@lijiarui lijiarui Awaiting requested review from lijiarui

Assignees

@abhishek-iiit abhishek-iiit

Labels
GSoD 2021 how to guide PR related to How-to-Guide section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update and enhance how-to-guide section
7 participants
@abhishek-iiit @proudofsimin @lijiarui @huan @shraddhavp @Rohitesh-Kumar-Jain @vasvi-sood