[GSoD 2021] Formatted actions and .vscode files using prettier #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
iamrajiv
changed the title
25 tasks
Rohitesh-Kumar-Jain
previously approved these changes
Jul 21, 2021
|
By the way, @iamrajiv, why you used prettier when modern IDEs could have just done in a single click? on a side note to perform this formatting you just need to press command + shift + L in jet brains IDEs |
huan
requested changes
Sep 6, 2021
There was a problem hiding this comment.
Thanks for enforcing the format to prettier, I believe it's good to have a consistent format across all the json/YAML files.
However, I'd like to keep the following two styles:
- Array should be one item per line:
- branches: [master] + branches: + - master
- Keep the trailing comma
- "typescript" + "typescript", ],
Please change your PR to keep the above two styles, and resolve the conflicts before we can continue reviewing it.
Thank you very much!
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
huan
requested changes
Sep 10, 2021
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
huan
reviewed
Sep 11, 2021
huan
requested changes
Sep 16, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: wechaty/docusaurus#1012