Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(i18n): fix header anchor for RTL #270

Merged
merged 2 commits into from
Feb 12, 2024
Merged

🐛 fix(i18n): fix header anchor for RTL #270

merged 2 commits into from
Feb 12, 2024

Conversation

TheAwiteb
Copy link
Collaborator

@TheAwiteb TheAwiteb commented Feb 11, 2024 •
edited
Loading

Fix #269

Will looks like after this PR

In English

untitled.mp4

In Arabic

untitled.mp4

@TheAwiteb TheAwiteb requested a review from welpo as a code owner February 11, 2024 18:46
@welpo
Copy link
Owner

welpo commented Feb 12, 2024

Hello!

Just pushed a commit to use the :dir() CSS pseudo-class to target the styling only for rtl text.

Can you please confirm it works as expected? I tested it locally and it looks good to me.

@TheAwiteb
Copy link
Collaborator Author

Can you please confirm it works as expected

Yes, is work great!!

@welpo welpo merged commit 009d2f6 into welpo:main Feb 12, 2024
1 check passed
@welpo welpo changed the title 🐛 fix(i18n): fix header anchor in arabic 🐛 fix(i18n): fix header anchor for RTL Feb 12, 2024
Smtbook pushed a commit to Smtbook/zola-theme-tabi that referenced this pull request Feb 29, 2024
@TheAwiteb @welpo @Smtbook
🐛 fix(i18n): fix header anchor for RTL (welpo#270)
39be9bd 
Co-authored-by: welpo <[email protected]>
welpo added a commit that referenced this pull request Sep 15, 2024
@welpo
🌐 style(RTL): improve RTL styling consistency
cd32625 
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #257 #262 #270 #272 #274 #368
@welpo welpo mentioned this pull request Sep 15, 2024
Merged
16 tasks
welpo added a commit that referenced this pull request Sep 15, 2024
@welpo
🌐 style(RTL): improve RTL styling consistency
d95749e 
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #262 #270 #272 #274 #368
welpo added a commit that referenced this pull request Sep 15, 2024
@welpo
🌐 style(RTL): improve RTL styling consistency
6a0c9f1 
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #262 #270 #272 #274 #368
welpo added a commit that referenced this pull request Sep 15, 2024
@welpo
🌐 style(RTL): improve RTL styling consistency
cd6e442 
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #262 #270 #272 #274 #368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welpo welpo Awaiting requested review from welpo welpo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header anchor in Arabic text is not working
2 participants
@TheAwiteb @welpo