Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(CSP): add Umami API URLs to CSP #301

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

arichtman
Copy link
Contributor

Summary

  • Added Umami's API gateway domains to the automatic Content Security Policy generation.

Related issue

closes #299

Changes

They should be live at https://www.richtman.au now and one can see the Config.toml here

Accessibility

No impact to accessibility.

Screenshots

No visual impact.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@arichtman arichtman requested a review from welpo as a code owner April 29, 2024 11:42
@welpo welpo changed the title 🐛 fix(content_security_policy.html): add Umami API gateway domains to CSP 🐛 fix(CSP): add Umami API URLs to CSP Apr 29, 2024
@welpo
Copy link
Owner

welpo commented Apr 29, 2024

Thank you!!

@welpo welpo merged commit 341b80a into welpo:main Apr 29, 2024
3 of 4 checks passed
@arichtman arichtman deleted the umami-csp branch April 29, 2024 12:51
@welpo welpo added the bug Something isn't working label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umami analytics blocked unless CSP is modified
2 participants