Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: add option to display/hide date in metadata #306

Merged
merged 1 commit into from
May 2, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented May 2, 2024

Summary

Adds show_date option to display/hide the date on pages. It follows the hierarchy.

Changes

Besides adding the option, this PR also adds logic to conditionally show the $SEPARATOR in the metadata. This avoids situations where the first element shown is the separator (e.g. hiding the date but showing reading time).

Related issue

Resolves #302.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo changed the title ✨ feat: adds option to display/hide date in metadata ✨ feat: add option to display/hide date in metadata May 2, 2024
@welpo welpo merged commit 0cbd727 into main May 2, 2024
3 of 5 checks passed
@welpo welpo deleted the feat/allow-hiding-date branch May 2, 2024 21:32
@welpo welpo added the enhancement New feature or request label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects in RSS Feed
1 participant