Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(rtl): fix blockquote in rtl #368

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

TheAwiteb
Copy link
Collaborator

Changes

New blockquote for RTL, where the border and padding in the right

Note

I have tried :dir(rtl) syntax but it doesn't work properly, also I tried to use [dir="rtl"] only without ltr, but it doesn't work

Screenshots

Before After
image image

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@TheAwiteb TheAwiteb requested a review from welpo as a code owner August 26, 2024 04:48
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 6d38384
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66cc6616b2d28a000889da1a
😎 Deploy Preview https://deploy-preview-368--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo force-pushed the fix-rtl-blockquote branch from bfce354 to 6d38384 Compare August 26, 2024 11:25
@welpo
Copy link
Owner

welpo commented Aug 26, 2024

Thanks for reporting and fixing this!

I've modified the CSS a bit to make it simpler: I just learnt about padding-inline-start and border-inline-start.

Could you test it and let me know if it works for you?

@TheAwiteb
Copy link
Collaborator Author

Could you test it and let me know if it works for you?

Yes it works properly

RTL LTR
image image

@welpo welpo merged commit 13d305a into welpo:main Aug 26, 2024
7 checks passed
@welpo
Copy link
Owner

welpo commented Aug 26, 2024

Thank you!

welpo added a commit that referenced this pull request Sep 15, 2024
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #257 #262 #270 #272 #274 #368
welpo added a commit that referenced this pull request Sep 15, 2024
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #262 #270 #272 #274 #368
welpo added a commit that referenced this pull request Sep 15, 2024
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #262 #270 #272 #274 #368
welpo added a commit that referenced this pull request Sep 15, 2024
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #262 #270 #272 #274 #368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants