Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS proxy improvements #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

hughbris
Copy link

I noticed the plugin's proxy URL was blocked by my webserver rules. It seemed like a problematic path anyway. So replaced the proxy path to /_cors/proxy by default (2b46aa3) and allowed it to be configured (662e9f3).

@wernerjoss
Copy link
Owner

Hello Hugh,
thanks for working on improvement of this project.
I have cloned your version to my local docker test instance and it works without problems, which is no wonder, as I'm not using any CORS proxy 😄
the Idea to provide a configurable proxy path sounds good, but, ATM, I can't test this as I do not have any more remote Calendars available .
then, I see that the formerly provided proxy, proxy.php, ist no more included, which does not seem convenient for people who do not know where to find one.
plus, what will happen to those who currently use the existing proxy.php after an update ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants