feat: 110268 111686 get questionnaire order periodically #7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arafubeatbox
commented
Dec 24, 2022
| @@ -138,6 +138,7 @@ | |||
| "next-superjson": "^0.0.4", | |||
| "next-themes": "^0.2.0", | |||
| "nocache": "^3.0.1", | |||
| "node-cron": "^3.0.2", | |||
There was a problem hiding this comment.
node 内の cron job 実行のために追加しました。
LICENSE 的に使って大丈夫だと思っています。
THIRD-PARTY-NOTICES はほぼ武井さんしかいじっていなかったので一旦いじりませんでした。
hakumizuki
changed the title
hakumizuki
suggested changes
Jan 5, 2023
Comment on lines
5
to
11
| const getRandomInt = (min: number, max: number): number => { | ||
| const minInt = Math.ceil(min); | ||
| const maxInt = Math.floor(max); | ||
| return Math.floor(Math.random() * (maxInt - minInt) + minInt); | ||
| }; | ||
|
|
||
| const sleep = msec => new Promise(resolve => setTimeout(resolve, msec)); |
There was a problem hiding this comment.
どっかの /utils あたりにファイル作って移動したいです
| @@ -646,6 +646,24 @@ const ENV_VAR_NAME_TO_CONFIG_INFO = { | |||
| type: ValueType.STRING, | |||
| default: null, | |||
| }, | |||
| GROWI_QUESTIONNAIRE_URI: { | |||
| ns: 'crowi', | |||
| key: 'app:growiQuestionnaireUri', | |||
There was a problem hiding this comment.
GROWI_QUESTIONNAIRE_SERVER_ORIGIN の方が直接的でいいかなと思います
Comment on lines
22
to
26
| constructor(crowi) { | ||
| this.growiQuestionnaireUri = crowi.configManager?.getConfig('crowi', 'app:growiQuestionnaireUri'); | ||
| this.cronSchedule = crowi.configManager?.getConfig('crowi', 'app:questionnaireCronSchedule'); | ||
| this.maxHoursUntilRequest = crowi.configManager?.getConfig('crowi', 'app:questionnaireCronMaxHoursUntilRequest'); | ||
| } |
There was a problem hiding this comment.
今回の場合は環境変数でしか設定値を変更しないので大丈夫なのですが、コンストラクタで設定値を初期化してしまうと、設定値を UI 上で変更可能にした場合などに対応できなくなってしまうので、使う時に取得するのがいいかと思います
| await sleep(secToSleep * 1000); | ||
|
|
||
| try { | ||
| const response = await axios.get(`${this.growiQuestionnaireUri}/questionnaire-order/index`); |
There was a problem hiding this comment.
axios-retry を使うと簡単にリトライできるので、もし余裕あれば変更お願いします。既に GROWI で使われてます
There was a problem hiding this comment.
softonic/axios-retry#159
custom axios instance を使おうとするとエラーが起こるみたいで、growi で現在使われている場所と同じく、default の axios を使うようにしました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review task: https://redmine.weseek.co.jp/issues/112130
実装内容
備考
一旦方針確認をしたいので、テストはその後に書きます。
weseek/growi にブランチ作成をすることができなかったので、collaborator ヘの追加、もしくは topic branch (feat/questionnaire など) の作成をお願いしてもよろしいでしょうか。一旦自分の fork から、master への draft PR で出しています。